MA0042: extend await-using suppression to more base types#1135
Merged
Conversation
Add direct-instantiation suppression logic for DbDataReader, DbTransaction, DbBatch, and TextWriter when DisposeAsync is not overridden, with matching MA0042 tests and docs updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced May 6, 2026
Closed
This was referenced May 7, 2026
Merged
Merged
Merged
This was referenced May 20, 2026
Closed
Closed
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
MA0042 already avoids suggesting
await usingfor directnewonStream,DbConnection, andDbCommandsubclasses whenDisposeAsyncis not overridden. The same false-positive pattern exists for other common framework base types whose defaultDisposeAsyncremains synchronous.What changed
newfor:DbDataReaderDbTransactionDbBatchTextWriterDisposeAsync.Create*()methods): diagnostics remain, because the runtime type may still provide an async override.Tests
Added focused coverage in
DoNotUseBlockingCallInAsyncContextAnalyzer_AsyncContextTestsfor each added base type:newwithoutDisposeAsyncoverride -> no diagnosticnewwith override -> diagnosticnewwith override in intermediate base -> diagnosticDocumentation
Updated
docs/Rules/MA0042.mdknown limitations to document the added base types and examples for direct-instantiation vs factory behavior.Contributes to #1134